git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] gitweb: start to generate PATH_INFO URLs.

From
Junio C Hamano <junkio@cox.net>
Date
Oct 3, 2006, 17:39 UTC
Message-ID
<7vbqotpadg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<eftkdk$2ii$3@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 8 quoted lines
> Martin Waitz wrote:
>
>> +       'pathinfo' => {
>> +               'override' => 0,
>> +               'default' => [1]},
>
> You should add failsafe to gitweb_check_feature for when 'sub' is not set;
> for example when somebody sets $feature{'pathinfo'}{'override'} to 1.

Yes, I noticed this last night while playing with it. We would at least need a big warning that says this should not be made overridable (which does not make any sense anyway).

Setting 'sub' to a failsafe one that only returns what is in the default without looking at individual repository would be the cleanest, I think.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 7 of 19 in “gitweb: start to generate PATH_INFO URLs”
  1. gitweb: start to generate PATH_INFO URLsMartin Waitz, Sep 29, 2006
  2. Junio C HamanoSep 29, 2006
  3. Martin WaitzSep 30, 2006
  4. Junio C HamanoSep 30, 2006
  5. gitweb: start to generate PATH_INFO URLs.Martin Waitz, Oct 1, 2006
  6. Jakub NarebskiOct 3, 2006
  7. Junio C HamanoOct 3, 2006
  8. Jakub NarebskiOct 3, 2006
  9. Junio C HamanoOct 3, 2006
  10. Martin WaitzOct 3, 2006
  11. gitweb: warn if feature cannot be overridden.Martin Waitz, Oct 3, 2006
  12. Jakub NarebskiOct 3, 2006
  13. gitweb: make PATHINFO URL generation conditional on input URL.Martin Waitz, Oct 3, 2006
  14. Petr BaudisOct 6, 2006
  15. Junio C HamanoOct 7, 2006
  16. Jakub NarebskiOct 3, 2006
  17. Martin WaitzOct 3, 2006
  18. Jakub NarebskiOct 3, 2006
  19. Junio C HamanoOct 3, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.