From: Junio C Hamano <junkio@cox.net>
Date: Tue, 03 Oct 2006 17:36:22 GMT
Subject: Re: [PATCH] gitweb: start to generate PATH_INFO URLs
Message-ID: <7vfye5pai1.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <20061003171229.GN2871@admingilde.org>

Martin Waitz <tali@admingilde.org> writes:

> On Tue, Oct 03, 2006 at 02:16:05PM +0200, Jakub Narebski wrote:
>> 
>> I have just modified href() to be able to use it for actions which don't
>> need the ?p= parameter... and you didn't take into consideration the case
>> when $params{'project'} is set, but undefined.
>
> is this handled correctly in the second patch which got committed to
> next?

I did only a light testing last night and I do not remember
testing this particular issue I did not see an obvious
breakage.  Could you two please verify and send in fixes if you
find any more issues around this area?

I think Jakub's suggestion to respond in PATH_INFO to requests
that does use PATH_INFO is a good one.