Re: [PATCH] gitweb: start to generate PATH_INFO URLs

From: Jakub Narebski <jnareb@gmail.com>
Date: Oct 3, 2006, 17:19 UTC
Message-ID: <efu62g$7f8$1@sea.gmane.org>
In-Reply-To: <20061003171229.GN2871@admingilde.org>

Martin Waitz wrote:

Show 11 quoted lines

> On Tue, Oct 03, 2006 at 02:16:05PM +0200, Jakub Narebski wrote:
>> Martin Waitz wrote:
>> > Instead of providing the project as a ?p= parameter it is simply appended
>> > to the base URI.
>> 
>> I have just modified href() to be able to use it for actions which don't
>> need the ?p= parameter... and you didn't take into consideration the case
>> when $params{'project'} is set, but undefined.
> 
> is this handled correctly in the second patch which got committed to
> next?

I think it is (from the examining the patch, not from testing).

Perhaps we should use PATH_INFO if current URL uses PATH_INFO...

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git