Re: [PATCH] gitweb: start to generate PATH_INFO URLs.

From: Junio C Hamano <junkio@cox.net>
Date: Oct 3, 2006, 20:16 UTC
Message-ID: <7vwt7hm9yq.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <efu7r9$fra$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

Show 24 quoted lines

> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>> 
>>> Martin Waitz wrote:
>>>
>>>> +       'pathinfo' => {
>>>> +               'override' => 0,
>>>> +               'default' => [1]},
>>>
>>> You should add failsafe to gitweb_check_feature for when 'sub' is not
> set;
>>> for example when somebody sets $feature{'pathinfo'}{'override'} to 1.
>> 
>> Yes, I noticed this last night while playing with it.  We would
>> at least need a big warning that says this should not be made
>> overridable (which does not make any sense anyway).
>> 
>> Setting 'sub' to a failsafe one that only returns what is in the
>> default without looking at individual repository would be the
>> cleanest, I think.
>
> Perhaps we should not add 'override' key, and test for existence
> of 'override' to fallback on 'sub'.

Excellent idea.  Please make it so.