git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv3] filter-branch: Add tests for submodules

From
Junio C Hamano <gitster@pobox.com>
Date
Jan 28, 2010, 00:14 UTC
Message-ID
<7vfx5rnl0w.fsf@alter.siamese.dyndns.org>
In-Reply-To
<1264636547-24496-1-git-send-email-sojkam1@fel.cvut.cz>
Michal Sojka <sojkam1@fel.cvut.cz> writes:
> There are three important tests:

It is unnecessary and counterproductive to self-proclaim the importance of a patch or new tests. If anything, what are important are not tests themselves but the conditions that they check, so "Add tests to check three important cases:" is slightly more palatable.

I'd suggest to just start with "Add three tests to make sure:".
> 1) 'rewrite submodule with another content' passes only with the
>    previous patch applied.

Sorry, but I think I am missing some context here to understand this sentence. Which previous patch?

Show 6 quoted lines
> 2) 'checkout submodule during rewrite' demonstrates that it is not
>    possible to replace a submodule revision in tree-filter by checking
>    the submodule out and reseting the submodule's HEAD. Fails both
>    with and without the previous patch. This is because filter-branch
>    sets GIT_WORKING_TREE to "." which causes clone (called from
>    git-submodule) to fail.

I thought you agreed with Hannes that this is not something we would even want to support?

Show 6 quoted lines
> 3) 'replace submodule revision' shows that replacing submodule
>    revision is possible by direct index manipulation. Succeeds both
>    with and without the previous patch.
>
> Signed-off-by: Michal Sojka <sojkam1@fel.cvut.cz>
> ---
Thanks.
Previous: Michal SojkaNext: Michal Sojka
Message 8 of 15 in “filter-branch fix and tests”
  1. Michal SojkaJan 25, 2010
  2. 1/2 filter-branch: Fix to allow replacing submodules with another contentMichal Sojka, Jan 25, 2010
  3. 2/2 filter-branch: Add tests for submodulesMichal Sojka, Jan 25, 2010
  4. Michal SojkaJan 27, 2010
  5. Johannes SixtJan 27, 2010
  6. Michal SojkaJan 27, 2010
  7. [PATCHv3] filter-branch: Add tests for submodulesMichal Sojka, Jan 27, 2010
  8. Junio C HamanoJan 28, 2010
  9. Michal SojkaJan 28, 2010
  10. 1/2 filter-branch: Fix to allow replacing submodules with another contentMichal Sojka, Jan 28, 2010
  11. 2/2 filter-branch: Add tests for submodules in tree-filterMichal Sojka, Jan 28, 2010
  12. Junio C HamanoJan 28, 2010
  13. Michal SojkaJan 29, 2010
  14. 1/2 filter-branch: Fix to allow replacing submodules with another contentMichal Sojka, Jan 29, 2010
  15. 2/2 filter-branch: Add tests for submodules in tree-filterMichal Sojka, Jan 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.