Re: [PATCHv4 2/2] filter-branch: Add tests for submodules in tree-filter

From: Junio C Hamano <gitster@pobox.com>
Date: Jan 28, 2010, 21:57 UTC
Message-ID: <7vaavxlwoz.fsf@alter.siamese.dyndns.org>
In-Reply-To: <1264669727-9977-2-git-send-email-sojkam1@fel.cvut.cz>

Michal Sojka <sojkam1@fel.cvut.cz> writes:

Show 6 quoted lines

> @@ -306,4 +306,43 @@ test_expect_success '--remap-to-ancestor with filename filters' '
>  	test $orig_invariant = $(git rev-parse invariant)
>  '
>  
> +test_expect_success 'setup submodule' '
> +	rm -rf * .*

Yikes.  Please don't do this.

If you cannot structure your tests following what has already been done by the previous tests, at least name the things that you want to remove a bit more explicitly to avoid mistakes. The loosest form that is reasonable would probably be (to catch a, actual, backup-refs, ... and .git):

	rm -fr ?* .?* &&

but it would be preferable to be even more explicit "rm -fr ?* .git".

Also make sure you don't break the chain of "&&" unnecessarily.

Show 8 quoted lines

> +	git init &&
> +	test_commit file &&
> +	mkdir submod &&
> +	submodurl="$PWD/submod"
> +	( cd submod &&
> +	  git init &&
> +	  test_commit file-in-submod ) &&
> +	git submodule add "$submodurl"

"&&"?