From: Junio C Hamano Date: Thu, 28 Jan 2010 00:14:07 GMT Subject: Re: [PATCHv3] filter-branch: Add tests for submodules Message-ID: <7vfx5rnl0w.fsf@alter.siamese.dyndns.org> In-Reply-To: <1264636547-24496-1-git-send-email-sojkam1@fel.cvut.cz> Michal Sojka writes: > There are three important tests: It is unnecessary and counterproductive to self-proclaim the importance of a patch or new tests. If anything, what are important are not tests themselves but the conditions that they check, so "Add tests to check three important cases:" is slightly more palatable. I'd suggest to just start with "Add three tests to make sure:". > 1) 'rewrite submodule with another content' passes only with the > previous patch applied. Sorry, but I think I am missing some context here to understand this sentence. Which previous patch? > 2) 'checkout submodule during rewrite' demonstrates that it is not > possible to replace a submodule revision in tree-filter by checking > the submodule out and reseting the submodule's HEAD. Fails both > with and without the previous patch. This is because filter-branch > sets GIT_WORKING_TREE to "." which causes clone (called from > git-submodule) to fail. I thought you agreed with Hannes that this is not something we would even want to support? > 3) 'replace submodule revision' shows that replacing submodule > revision is possible by direct index manipulation. Succeeds both > with and without the previous patch. > > Signed-off-by: Michal Sojka > --- Thanks.