git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCHv4 2/2] filter-branch: Add tests for submodules in tree-filter

From
Michal Sojka <sojkam1@fel.cvut.cz>
Date
Jan 29, 2010, 15:20 UTC
Message-ID
<201001291620.35269.sojkam1@fel.cvut.cz>
In-Reply-To
<7vaavxlwoz.fsf@alter.siamese.dyndns.org>
On Thursday 28 of January 2010 22:57:16 Junio C Hamano wrote:
Show 9 quoted lines
> Michal Sojka <sojkam1@fel.cvut.cz> writes:
> > +test_expect_success 'setup submodule' '
> > +	rm -rf * .*
> 
> Yikes.  Please don't do this.
> 
> [...]
> 
> but it would be preferable to be even more explicit "rm -fr ?* .git".
Fixed. I did it like you suggested.
> Also make sure you don't break the chain of "&&" unnecessarily.
> 
Fixed.

I've also split each my test into two separate tests. In the first one I perform the rewrite and in the second I test that the result is what was expected. I did it because the other tests in this file are structured the same way.

Cheers, Michal

Previous: Junio C HamanoNext: Michal Sojka
Message 13 of 15 in “filter-branch fix and tests”
  1. Michal SojkaJan 25, 2010
  2. 1/2 filter-branch: Fix to allow replacing submodules with another contentMichal Sojka, Jan 25, 2010
  3. 2/2 filter-branch: Add tests for submodulesMichal Sojka, Jan 25, 2010
  4. Michal SojkaJan 27, 2010
  5. Johannes SixtJan 27, 2010
  6. Michal SojkaJan 27, 2010
  7. [PATCHv3] filter-branch: Add tests for submodulesMichal Sojka, Jan 27, 2010
  8. Junio C HamanoJan 28, 2010
  9. Michal SojkaJan 28, 2010
  10. 1/2 filter-branch: Fix to allow replacing submodules with another contentMichal Sojka, Jan 28, 2010
  11. 2/2 filter-branch: Add tests for submodules in tree-filterMichal Sojka, Jan 28, 2010
  12. Junio C HamanoJan 28, 2010
  13. Michal SojkaJan 29, 2010
  14. 1/2 filter-branch: Fix to allow replacing submodules with another contentMichal Sojka, Jan 29, 2010
  15. 2/2 filter-branch: Add tests for submodules in tree-filterMichal Sojka, Jan 29, 2010

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.