git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type

From
Junio C Hamano <junkio@cox.net>
Date
Sep 4, 2006, 23:17 UTC
Message-ID
<7vejurkyro.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<edib58$61k$1@sea.gmane.org>
Jakub Narebski <jnareb@gmail.com> writes:
Show 16 quoted lines
> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>> 
>>> Jakub Narebski wrote:
>>>
>>>> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644
>>>
>>> Hmmm... I do wonder why --binary implies --full-index option.
>> 
>> Patch safety.  Yours happened to be a creation patch so it might
>> not matter in this particular case, but we would want to be
>> reasonably sure there is no ambiguity in the preimage when you
>> are doing a modification patch.
>  
> Couldn't we do this (show full sha1) only for the binary part of patch?

Personally I would say why bother, but patches welcome if cleanly done.

Previous: Jakub NarebskiNext: Jakub Narebski
Message 8 of 14 in “gitweb: Some improvements”
  1. 0/4 gitweb: Some improvementsJakub Narebski, Sep 4, 2006
  2. PATCH 1/4] gitweb: Add GIT favicon, assuming image/png typeJakub Narebski, Sep 4, 2006
  3. Linus TorvaldsSep 4, 2006
  4. 1/4 gitweb: Add GIT favicon, assuming image/png typeJakub Narebski, Sep 4, 2006
  5. Jakub NarebskiSep 4, 2006
  6. Junio C HamanoSep 4, 2006
  7. Jakub NarebskiSep 4, 2006
  8. Junio C HamanoSep 4, 2006
  9. 2/4 gitweb: Change the name of diff to parent link in "commit" view to "diff"Jakub Narebski, Sep 4, 2006
  10. 3/4 gitweb: Divide page path into directories -- path's "breadcrumbs"Jakub Narebski, Sep 4, 2006
  11. 4/4 gitweb: Correct typo: '==' instead of 'eq' in git_difftree_bodyJakub Narebski, Sep 4, 2006
  12. Junio C HamanoSep 4, 2006
  13. Jakub NarebskiSep 4, 2006
  14. Jakub NarebskiSep 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.