From: Junio C Hamano <junkio@cox.net>
Date: Mon, 04 Sep 2006 23:17:15 GMT
Subject: Re: [PATCH 1/4] gitweb: Add GIT favicon, assuming image/png type
Message-ID: <7vejurkyro.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <edib58$61k$1@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

> Junio C Hamano wrote:
>
>> Jakub Narebski <jnareb@gmail.com> writes:
>> 
>>> Jakub Narebski wrote:
>>>
>>>> index 199fbe87384cd3f4686916277dd124cefc751e8a..f3b762de92e579300eba3f53ee26b2a80b4e76c7 100644
>>>
>>> Hmmm... I do wonder why --binary implies --full-index option.
>> 
>> Patch safety.  Yours happened to be a creation patch so it might
>> not matter in this particular case, but we would want to be
>> reasonably sure there is no ambiguity in the preimage when you
>> are doing a modification patch.
>  
> Couldn't we do this (show full sha1) only for the binary part of patch?

Personally I would say why bother, but patches welcome if
cleanly done.