git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 2/4] gitweb: Change the name of diff to parent link in "commit" view to "diff"

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 4, 2006, 16:15 UTC
Message-ID
<200609041815.29203.jnareb@gmail.com>
In-Reply-To
<200609041810.09838.jnareb@gmail.com>

Change the name of diff to parent (current commit to one of parents) link in "commit" view (git_commit subroutine) from "commitdiff" to "diff". Let's leave "commitdiff" for equivalent of git-show, or git-diff-tree with one revision, i.e. diff for a given commit to its parent (parents).

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
The commit message is barely smaller than the diff itself, but it
is expected as commit message tell the why behind the change.
 gitweb/gitweb.perl |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index bebaa0f..3b5c0e2 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -2758,7 +2758,7 @@ sub git_commit {
 		      "<td class=\"link\">" .
 		      $cgi->a({-href => href(action=>"commit", hash=>$par)}, "commit") .
 		      " | " .
-		      $cgi->a({-href => href(action=>"commitdiff", hash=>$hash, hash_parent=>$par)}, "commitdiff") .
+		      $cgi->a({-href => href(action=>"commitdiff", hash=>$hash, hash_parent=>$par)}, "diff") .
 		      "</td>" .
 		      "</tr>\n";
 	}
-- 
1.4.1.1
Previous: Junio C HamanoNext: Jakub Narebski
Message 9 of 14 in “gitweb: Some improvements”
  1. 0/4 gitweb: Some improvementsJakub Narebski, Sep 4, 2006
  2. PATCH 1/4] gitweb: Add GIT favicon, assuming image/png typeJakub Narebski, Sep 4, 2006
  3. Linus TorvaldsSep 4, 2006
  4. 1/4 gitweb: Add GIT favicon, assuming image/png typeJakub Narebski, Sep 4, 2006
  5. Jakub NarebskiSep 4, 2006
  6. Junio C HamanoSep 4, 2006
  7. Jakub NarebskiSep 4, 2006
  8. Junio C HamanoSep 4, 2006
  9. 2/4 gitweb: Change the name of diff to parent link in "commit" view to "diff"Jakub Narebski, Sep 4, 2006
  10. 3/4 gitweb: Divide page path into directories -- path's "breadcrumbs"Jakub Narebski, Sep 4, 2006
  11. 4/4 gitweb: Correct typo: '==' instead of 'eq' in git_difftree_bodyJakub Narebski, Sep 4, 2006
  12. Junio C HamanoSep 4, 2006
  13. Jakub NarebskiSep 4, 2006
  14. Jakub NarebskiSep 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.