Re: [PATCH 0/4] gitweb: Some improvements

From: Jakub Narebski <jnareb@gmail.com>
Date: Sep 4, 2006, 23:53 UTC
Message-ID: <ediea9$d3d$2@sea.gmane.org>
In-Reply-To: <7v8xkzkyie.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

Show 18 quoted lines

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> This is small series of patches, applicable both to 'master' and 'next',
>> which adds simple improvements, or in the case of last patch
>> fix bug/typo.
>>
>> First two patches were sent earlier, I don't know if they were dropped
>> or forgotten. 
> 
> I think you were just expecting too quick turnaround ;-).
> 
> If I recall correctly it used to be that we could not use png
> for favicon but it seems that things have improved.
> 
> It is a while since I tried gitweb on my machine the last time
> but was it always this slow I wonder...  We probably would need
> a good benchmark and automated test before going too much
> further.

The problem is that before commit 5d043a3d856bd40d8b34b8836a561e438d23573b
  gitweb: fill in gitweb configuration by Makefile
by Martin Waitz one had to modify gitweb script to change the configuration
from default.

But benchmarking is good. Simple time to run script from command line, with environment variables GATEWAY_INTERFACE="CGI/1.1", HTTP_ACCEPT="*/*", REQUEST_METHOD="GET" and of course QUERY_STRING set, and perhaps using ApacheBench.

>From my experience with gitweb, the longest it take to show summary and tags

views (for a large number of tags, which grows linearly with history), and to show history (and of course blame).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git