git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH 4/4] gitweb: Correct typo: '==' instead of 'eq' in git_difftree_body

From
Jakub Narebski <jnareb@gmail.com>
Date
Sep 4, 2006, 16:19 UTC
Message-ID
<200609041819.58737.jnareb@gmail.com>
In-Reply-To
<200609041810.09838.jnareb@gmail.com>
Signed-off-by: Jakub Narebski <jnareb@gmail.com>
---
This caused that the "commitdiff" version, with "patch" link to anchor
instead of "diff" link to "blobdiff" view was used even in "commit" view.
 gitweb/gitweb.perl |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 4240a30..e7d7bd7 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -1519,7 +1519,7 @@ sub git_difftree_body {
 			      $cgi->a({-href => href(action=>"blob", hash=>$diff{'to_id'},
 			                             hash_base=>$hash, file_name=>$diff{'file'})},
 			              "blob");
-			if ($action == "commitdiff") {
+			if ($action eq 'commitdiff') {
 				# link to patch
 				$patchno++;
 				print " | " .
@@ -1540,7 +1540,7 @@ sub git_difftree_body {
 			                             hash_base=>$parent, file_name=>$diff{'file'})},
 			              "blob") .
 			      " | ";
-			if ($action == "commitdiff") {
+			if ($action eq 'commitdiff') {
 				# link to patch
 				$patchno++;
 				print " | " .
@@ -1586,7 +1586,7 @@ sub git_difftree_body {
 			                             hash_base=>$hash, file_name=>$diff{'file'})},
 			              "blob");
 			if ($diff{'to_id'} ne $diff{'from_id'}) { # modified
-				if ($action == "commitdiff") {
+				if ($action eq 'commitdiff') {
 					# link to patch
 					$patchno++;
 					print " | " .
@@ -1628,7 +1628,7 @@ sub git_difftree_body {
 			                             hash=>$diff{'to_id'}, file_name=>$diff{'to_file'})},
 			              "blob");
 			if ($diff{'to_id'} ne $diff{'from_id'}) {
-				if ($action == "commitdiff") {
+				if ($action eq 'commitdiff') {
 					# link to patch
 					$patchno++;
 					print " | " .
-- 
1.4.1.1
Previous: Jakub NarebskiNext: Junio C Hamano
Message 11 of 14 in “gitweb: Some improvements”
  1. 0/4 gitweb: Some improvementsJakub Narebski, Sep 4, 2006
  2. PATCH 1/4] gitweb: Add GIT favicon, assuming image/png typeJakub Narebski, Sep 4, 2006
  3. Linus TorvaldsSep 4, 2006
  4. 1/4 gitweb: Add GIT favicon, assuming image/png typeJakub Narebski, Sep 4, 2006
  5. Jakub NarebskiSep 4, 2006
  6. Junio C HamanoSep 4, 2006
  7. Jakub NarebskiSep 4, 2006
  8. Junio C HamanoSep 4, 2006
  9. 2/4 gitweb: Change the name of diff to parent link in "commit" view to "diff"Jakub Narebski, Sep 4, 2006
  10. 3/4 gitweb: Divide page path into directories -- path's "breadcrumbs"Jakub Narebski, Sep 4, 2006
  11. 4/4 gitweb: Correct typo: '==' instead of 'eq' in git_difftree_bodyJakub Narebski, Sep 4, 2006
  12. Junio C HamanoSep 4, 2006
  13. Jakub NarebskiSep 4, 2006
  14. Jakub NarebskiSep 5, 2006

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.