git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Introduce SHA1_FILE_DIRECTORIES

From
Junio C Hamano <junkio@cox.net>
Date
May 7, 2005, 06:31 UTC
Message-ID
<7vbr7nbl89.fsf@assigned-by-dhcp.cox.net>
In-Reply-To
<2721.10.10.10.24.1115425962.squirrel@linux1>
>>>>> "S" == Sean  <seanlkml@sympatico.ca> writes:
S> Perhaps I'm just missing something in your code,...

Yes you are. You have spotted a very inconvenient inconsistency in the interface to the code.

Only on the very first time when it tries to constructs the alternate directory list, and if there is no alternate list, it just returns the name without stat(), which forces the callers to do stat() themselves all the time. I think I should make it always stat, since the reading side needs do it anyway.

Thankfully I think Linus had rejected this part in the series. I'll fix it up.

Previous: SeanNext: Junio C Hamano
Message 5 of 30 in “Introduce SHA1_FILE_DIRECTORIES”
  1. Introduce SHA1_FILE_DIRECTORIESJunio C Hamano, May 6, 2005
  2. SeanMay 7, 2005
  3. Junio C HamanoMay 7, 2005
  4. SeanMay 7, 2005
  5. Junio C HamanoMay 7, 2005
  6. Junio C HamanoMay 7, 2005
  7. H. Peter AnvinMay 9, 2005
  8. Junio C HamanoMay 9, 2005
  9. SeanMay 9, 2005
  10. H. Peter AnvinMay 9, 2005
  11. Junio C HamanoMay 9, 2005
  12. [RFC] Renaming environment variables.Junio C Hamano, May 9, 2005
  13. Thomas GlanzmannMay 9, 2005
  14. Petr BaudisMay 10, 2005
  15. SeanMay 9, 2005
  16. Daniel BarkalowMay 9, 2005
  17. Junio C HamanoMay 10, 2005
  18. Petr BaudisMay 10, 2005
  19. Junio C HamanoMay 10, 2005
  20. Petr BaudisMay 10, 2005
  21. Daniel BarkalowMay 10, 2005
  22. Petr BaudisMay 10, 2005
  23. Daniel BarkalowMay 10, 2005
  24. Junio C HamanoMay 10, 2005
  25. Introducing GIT_DIR environment variable.Junio C Hamano, May 10, 2005
  26. Alex RiesenMay 10, 2005
  27. Junio C HamanoMay 10, 2005
  28. Daniel BarkalowMay 10, 2005
  29. Petr BaudisMay 10, 2005
  30. Junio C HamanoMay 10, 2005

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.