Re: [PATCH] Introduce SHA1_FILE_DIRECTORIES

From: Sean <seanlkml@sympatico.ca>
Date: May 9, 2005, 16:41 UTC
Message-ID: <3087.10.10.10.24.1115656919.squirrel@linux1>
In-Reply-To: <7vll6oz755.fsf@assigned-by-dhcp.cox.net>

On Mon, May 9, 2005 12:38 pm, Junio C Hamano said:

Show 17 quoted lines

>>>>>> "HPA" == H Peter Anvin <hpa@zytor.com> writes:
>
> HPA> Naming the environment variables SHA1_FILE_<anything> is almost
> HPA> certainly wrong; a much more logical name would be
> HPA> GIT_<something>. It'd also be much less likely to cause conflicts.
>
> Exactly my feeling from the beginning.
>
> But you have to realize that you are suggesting to change the
> SHA1_FILE_DIRECTORY that was there from almost the beginning as
> well.  I know the code change required for the rename is
> minimum, but there are users involved.  My feeling is that we
> should contain the damage by changing the definition of
> DB_ENVIRONMENT in cache.h sooner rather than later, but I do not
> think this is the week to do it.
>
>

What about creating a transition plan that uses the GIT_ name if it exists
and the SHA1_ name if it doesn't.  And mark the SHA1_ name as depreciated.
 That should be okay to do this week, no?

Sean