From: Junio C Hamano <junkio@cox.net>
Date: Sat, 07 May 2005 06:31:34 GMT
Subject: Re: [PATCH] Introduce SHA1_FILE_DIRECTORIES
Message-ID: <7vbr7nbl89.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <2721.10.10.10.24.1115425962.squirrel@linux1>

>>>>> "S" == Sean  <seanlkml@sympatico.ca> writes:

S> Perhaps I'm just missing something in your code,...

Yes you are.  You have spotted a very inconvenient inconsistency
in the interface to the code.

Only on the very first time when it tries to constructs the
alternate directory list, and if there is no alternate list, it
just returns the name without stat(), which forces the callers
to do stat() themselves all the time.  I think I should make it
always stat, since the reading side needs do it anyway.

Thankfully I think Linus had rejected this part in the series.
I'll fix it up.