Re: [RFC] Renaming environment variables.

From: Daniel Barkalow <barkalow@iabervon.org>
Date: May 9, 2005, 23:08 UTC
Message-ID: <Pine.LNX.4.21.0505091847050.30848-100000@iabervon.org>
In-Reply-To: <7vhdhcxj0z.fsf_-_@assigned-by-dhcp.cox.net>

On Mon, 9 May 2005, Junio C Hamano wrote:

Show 17 quoted lines

> H. Peter Anvin mentioned that using SHA1_whatever as an
> environment variable name is not nice and we should instead use
> names starting with "GIT_" prefix to avoid conflicts.
> 
> Here is a patch, requesting for comments.
> 
>  - Renames the following environment variables:
> 
>     New name                Old Name
> 
>     GIT_AUTHOR_DATE         AUTHOR_DATE
>     GIT_AUTHOR_EMAIL        AUTHOR_EMAIL
>     GIT_AUTHOR_NAME         AUTHOR_NAME
>     GIT_COMMIT_AUTHOR_EMAIL COMMIT_AUTHOR_EMAIL
>     GIT_COMMIT_AUTHOR_NAME  COMMIT_AUTHOR_NAME
>     GIT_ALTERNATE_OBJECTS   SHA1_FILE_DIRECTORIES
>     GIT_OBJECTS             SHA1_FILE_DIRECTORY

While we're at it, it would be useful to have one for what is normally ".git", rather than just ".git/objects". That way the same variable would be useful for finding other things in the .git directory, and I haven't heard of any use of SHA1_FILE_DIRECTORY that didn't end in /objects anyway, and would enable the brokenness in init-db (it creates ".git", and then tries to create "<obj-dir>/00-ff").

	-Daniel
*This .sig left intentionally blank*