Re: [PATCH] Introduce SHA1_FILE_DIRECTORIES
- From
Junio C Hamano <junkio@cox.net>
- Date
- May 9, 2005, 16:38 UTC
- Message-ID
- <7vll6oz755.fsf@assigned-by-dhcp.cox.net>
- In-Reply-To
- <427F6693.2080707@zytor.com>
>>>>> "HPA" == H Peter Anvin <hpa@zytor.com> writes:
HPA> Naming the environment variables SHA1_FILE_<anything> is almost HPA> certainly wrong; a much more logical name would be HPA> GIT_<something>. It'd also be much less likely to cause conflicts.
Exactly my feeling from the beginning.
But you have to realize that you are suggesting to change the SHA1_FILE_DIRECTORY that was there from almost the beginning as well. I know the code change required for the rename is minimum, but there are users involved. My feeling is that we should contain the damage by changing the definition of DB_ENVIRONMENT in cache.h sooner rather than later, but I do not think this is the week to do it.