From: Junio C Hamano <junkio@cox.net>
Date: Tue, 03 Oct 2006 17:39:07 GMT
Subject: Re: [PATCH] gitweb: start to generate PATH_INFO URLs.
Message-ID: <7vbqotpadg.fsf@assigned-by-dhcp.cox.net>
In-Reply-To: <eftkdk$2ii$3@sea.gmane.org>

Jakub Narebski <jnareb@gmail.com> writes:

> Martin Waitz wrote:
>
>> +       'pathinfo' => {
>> +               'override' => 0,
>> +               'default' => [1]},
>
> You should add failsafe to gitweb_check_feature for when 'sub' is not set;
> for example when somebody sets $feature{'pathinfo'}{'override'} to 1.

Yes, I noticed this last night while playing with it.  We would
at least need a big warning that says this should not be made
overridable (which does not make any sense anyway).

Setting 'sub' to a failsafe one that only returns what is in the
default without looking at individual repository would be the
cleanest, I think.