git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v5 3/3] Color skipped tests bold blue

From
Junio C Hamano <gitster@pobox.com>
Date
Sep 20, 2012, 16:20 UTC
Message-ID
<7va9wkd5u6.fsf@alter.siamese.dyndns.org>
In-Reply-To
<505AEB1B.7010702@gmail.com>
Stefano Lattarini <stefano.lattarini@gmail.com> writes:
Show 17 quoted lines
> Hi Adam.
>
> On 09/20/2012 11:08 AM, Adam Spiers wrote:
>> Skipped tests indicate incomplete test coverage.  Whilst this is
>> not a test failure or other error, it's still not complete
>> success, so according to the universal traffic lights coloring
>> scheme, yellow/brown seems more suitable than green.  However,
>> it's more informational than cautionary, so instead we use blue
>> which is a universal color for information signs.  Bold blue
>> should work better on both black and white backgrounds than
>> normal blue.
>>
> A very minor nit (feel free to ignore it): IMHO, it should be nice
> to state explicitly in the commit message that blue is already used
> by other testsuite-related software to highlight skipped tests; you
> can report the examples of at least Automake, Autotest and prove --
> and extra kudos if you find further examples ;-)

Thanks. Will tweak the proposed log message to include the above when queuing the updated patch.

Previous: Stefano LattariniNext: Jeff King
Message 12 of 18 in “Make test output coloring more intuitive”
  1. Make test output coloring more intuitiveAdam Spiers, Sep 17, 2012
  2. Jeff KingSep 17, 2012
  3. Adam SpiersSep 18, 2012
  4. Stefano LattariniSep 19, 2012
  5. Adam SpiersSep 19, 2012
  6. Jeff KingSep 19, 2012
  7. 3/6 Color skipped tests blueAdam Spiers, Sep 19, 2012
  8. Johannes SixtSep 20, 2012
  9. Adam SpiersSep 20, 2012
  10. 3/3 Color skipped tests bold blueAdam Spiers, Sep 20, 2012
  11. Stefano LattariniSep 20, 2012
  12. Junio C HamanoSep 20, 2012
  13. Jeff KingSep 21, 2012
  14. Adam SpiersNov 11, 2012
  15. Junio C HamanoSep 17, 2012
  16. Adam SpiersSep 18, 2012
  17. Jeff KingSep 18, 2012
  18. Adam SpiersSep 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.