Re: [PATCH] Make test output coloring more intuitive
- From
Jeff King <peff@peff.net>
- Date
- Sep 17, 2012, 20:11 UTC
- Message-ID
- <20120917201119.GB24888@sigill.intra.peff.net>
- In-Reply-To
- <1347882637-21766-1-git-send-email-git@adamspiers.org>
On Mon, Sep 17, 2012 at 12:50:37PM +0100, Adam Spiers wrote:
Show 10 quoted lines
> The end result of these changes is that: > > - red is _only_ used for things which have gone unexpectedly wrong: > test failures, unexpected test passes, and failures with the > framework, > > - yellow is _only_ used for known breakages, and > > - green is _only_ used for things which have gone to plan and > require no further work to be done.
Sounds reasonable, and I think the new output looks nice. I notice that skipped tests are still in green. I wonder if they should be in yellow, too. They may or may not be a problem, but you are failing to run some portion of the test suite.
Show 18 quoted lines
> diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh > index ae6a3f0..4e111b4 100755 > --- a/t/t0000-basic.sh > +++ b/t/t0000-basic.sh > @@ -81,9 +81,10 @@ test_expect_success 'pretend we have fixed a known breakage (run in sub test-lib > ./passing-todo.sh >out 2>err && > ! test -s err && > sed -e 's/^> //' >expect <<-\\EOF && > - > ok 1 - pretend we have fixed a known breakage # TODO known breakage > - > # fixed 1 known breakage(s) > - > # passed all 1 test(s) > + > ok 1 - pretend we have fixed a known breakage # TODO known breakage vanished > + > # fixed 1 known breakage(s); please update test(s) > + > # still have 1 known breakage(s) > + > # passed all remaining 0 test(s) > > 1..1 > EOF > test_cmp expect out)
This hunk is surprising after reading the commit message. It looks like you are also breaking down expect_fail tests by fixed and not fixed.
I think that is probably an OK thing to do (although it might make more sense in a separate patch), but are your numbers right? It looks from that count as if there are 2 tests expecting failure (one fixed and one still broken).
-Peff