From: Junio C Hamano Date: Thu, 20 Sep 2012 16:20:01 GMT Subject: Re: [PATCH v5 3/3] Color skipped tests bold blue Message-ID: <7va9wkd5u6.fsf@alter.siamese.dyndns.org> In-Reply-To: <505AEB1B.7010702@gmail.com> Stefano Lattarini writes: > Hi Adam. > > On 09/20/2012 11:08 AM, Adam Spiers wrote: >> Skipped tests indicate incomplete test coverage. Whilst this is >> not a test failure or other error, it's still not complete >> success, so according to the universal traffic lights coloring >> scheme, yellow/brown seems more suitable than green. However, >> it's more informational than cautionary, so instead we use blue >> which is a universal color for information signs. Bold blue >> should work better on both black and white backgrounds than >> normal blue. >> > A very minor nit (feel free to ignore it): IMHO, it should be nice > to state explicitly in the commit message that blue is already used > by other testsuite-related software to highlight skipped tests; you > can report the examples of at least Automake, Autotest and prove -- > and extra kudos if you find further examples ;-) Thanks. Will tweak the proposed log message to include the above when queuing the updated patch.