git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v5 3/3] Color skipped tests bold blue

From
Adam Spiers <git@adamspiers.org>
Date
Sep 20, 2012, 09:08 UTC
Message-ID
<1348132118-23139-1-git-send-email-git@adamspiers.org>
In-Reply-To
<505AAE34.2020408@viscovery.net>

Skipped tests indicate incomplete test coverage. Whilst this is not a test failure or other error, it's still not complete success, so according to the universal traffic lights coloring scheme, yellow/brown seems more suitable than green. However, it's more informational than cautionary, so instead we use blue which is a universal color for information signs. Bold blue should work better on both black and white backgrounds than normal blue.

Signed-off-by: Adam Spiers <git@adamspiers.org>
---
 t/test-lib.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 5293830..5ef87d4 100755
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -182,13 +182,13 @@ then
 		error)
 			tput bold; tput setaf 1;; # bold red
 		skip)
-			tput bold; tput setaf 2;; # bold green
+			tput bold; tput setaf 4;; # bold blue
 		warn)
 			tput bold; tput setaf 3;; # bold yellow
 		pass)
 			tput setaf 2;;            # green
 		info)
-			tput setaf 3;;            # brown
+			tput setaf 3;;            # yellow/brown
 		*)
 			test -n "$quiet" && return;;
 		esac
-- 
1.7.12.147.g6d168f4
Previous: Adam SpiersNext: Stefano Lattarini
Message 10 of 18 in “Make test output coloring more intuitive”
  1. Make test output coloring more intuitiveAdam Spiers, Sep 17, 2012
  2. Jeff KingSep 17, 2012
  3. Adam SpiersSep 18, 2012
  4. Stefano LattariniSep 19, 2012
  5. Adam SpiersSep 19, 2012
  6. Jeff KingSep 19, 2012
  7. 3/6 Color skipped tests blueAdam Spiers, Sep 19, 2012
  8. Johannes SixtSep 20, 2012
  9. Adam SpiersSep 20, 2012
  10. 3/3 Color skipped tests bold blueAdam Spiers, Sep 20, 2012
  11. Stefano LattariniSep 20, 2012
  12. Junio C HamanoSep 20, 2012
  13. Jeff KingSep 21, 2012
  14. Adam SpiersNov 11, 2012
  15. Junio C HamanoSep 17, 2012
  16. Adam SpiersSep 18, 2012
  17. Jeff KingSep 18, 2012
  18. Adam SpiersSep 18, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.