Re: [PATCH v4 3/6] Color skipped tests blue

From: Jeff King <peff@peff.net>
Date: Sep 21, 2012, 06:13 UTC
Message-ID: <20120921061325.GA15867@sigill.intra.peff.net>
In-Reply-To: <1348086263-27555-1-git-send-email-git@adamspiers.org>

On Wed, Sep 19, 2012 at 09:24:23PM +0100, Adam Spiers wrote:

Show 20 quoted lines

>  t/test-lib.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/t/test-lib.sh b/t/test-lib.sh
> index 5293830..78c88c2 100755
> --- a/t/test-lib.sh
> +++ b/t/test-lib.sh
> @@ -182,13 +182,13 @@ then
>  		error)
>  			tput bold; tput setaf 1;; # bold red
>  		skip)
> -			tput bold; tput setaf 2;; # bold green
> +			tput setaf 4;;            # blue
>  		warn)
>  			tput bold; tput setaf 3;; # bold yellow
>  		pass)
>  			tput setaf 2;;            # green
>  		info)
> -			tput setaf 3;;            # brown
> +			tput setaf 3;;            # yellow/brown

I happened to be running a test script with "-v" earlier today, and I noticed that the "expecting success..." dump of the test contents is also yellow. By your new rules, shouldn't it be blue?

I think it is matching the "info" type, which from the discussion should be blue, no?

Maybe it is just my terminal. I see it is labeled as "brown" here, but it looks very yellow (and I am using the stock xterm colors. According to:

  https://en.wikipedia.org/wiki/ANSI_colors

It looks it really is brown on some platforms. I'm not sure if it is worth worrying about. I don't really want to get into configurable colors just for the test-suite output.

-Peff