From: Junio C Hamano <gitster@pobox.com>
Date: Thu, 20 Aug 2009 04:13:58 GMT
Subject: Re: [PATCH] Add test case for rev-list --parents --show-all
Message-ID: <7v7hwzt94p.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20090819225852.GA21187@facebook.com>

Adam Simpkins <simpkins@facebook.com> writes:

> This test case ensures that rev-list --parents --show-all gets the
> parent history correct.  Normally, --parents rewrites parent history to
> skip TREESAME parents.  However, --show-all causes TREESAME parents to
> still be included in the revision list, so the parents should still be
> included too.
>
> Signed-off-by: Adam Simpkins <simpkins@facebook.com>
> ---
>
> Looking through the code, I believe TREESAME commits are the only ones
> affected by my earlier bug in simplify_commit().

What I meant was actually a test for the graph part (i.e. the problem we
would see if we did not apply your update to graph_is_interesting()), but
protecting the simplify_commit() logic with test from breakage is a good
thing to do as well.

Thanks.