git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Define $PERL_PATH in test-lib.sh

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 10, 2009, 20:17 UTC
Message-ID
<7v7hty6so9.fsf@alter.siamese.dyndns.org>
In-Reply-To
<20091110133427.GC8896@plop>
"Philippe Bruhat (BooK)" <book@cpan.org> writes:
Show 12 quoted lines
> On Tue, Nov 10, 2009 at 01:26:53PM +0100, Johannes Sixt wrote:
>> >  
>> > +test -z "$NO_PERL" && test -z "$PERL_PATH" && export PERL_PATH=/usr/bin/perl
>> 
>> Wouldn't
>> 
>>    ... && export PERL_PATH=perl
>> 
>> be a safer fall-back?
>
> /usr/bin/perl is the value used in the top-level Makefile.
> I used this for consistency.

Hmm, but that means two separate definitions in ./Makefile and t/test-lib.sh must be kept in sync forever, and there is not even a comment next to the line that requires such care in your patch to help people who might want to change these lines in the future.

Previous: Philippe Bruhat (BooK)Next: Philippe Bruhat (BooK)
Message 16 of 18 in “Define $PERL_PATH in test-lib.sh”
  1. Define $PERL_PATH in test-lib.shPhilippe Bruhat (BooK), Nov 10, 2009
  2. Jeff KingNov 10, 2009
  3. Philippe Bruhat (BooK)Nov 10, 2009
  4. Junio C HamanoNov 15, 2009
  5. Philippe Bruhat (BooK)Nov 16, 2009
  6. Make sure $PERL_PATH is defined when the test suite is run.Philippe Bruhat (BooK), Nov 16, 2009
  7. Junio C HamanoNov 17, 2009
  8. Philippe Bruhat (BooK)Nov 17, 2009
  9. Make sure $PERL_PATH is defined when the test suite is run.Philippe Bruhat (BooK), Nov 17, 2009
  10. Johannes SixtNov 17, 2009
  11. Philippe Bruhat (BooK)Nov 17, 2009
  12. Junio C HamanoNov 17, 2009
  13. Make sure $PERL_PATH is defined when the test suite is run.Philippe Bruhat (BooK), Nov 17, 2009
  14. Johannes SixtNov 10, 2009
  15. Philippe Bruhat (BooK)Nov 10, 2009
  16. Junio C HamanoNov 10, 2009
  17. Philippe Bruhat (BooK)Nov 11, 2009
  18. Jeff KingNov 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.