Re: [PATCH] Define $PERL_PATH in test-lib.sh
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Nov 15, 2009, 09:12 UTC
- Message-ID
- <7v639cqhh6.fsf@alter.siamese.dyndns.org>
- In-Reply-To
- <20091110122315.GA15906@coredump.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 7 quoted lines
> On Tue, Nov 10, 2009 at 11:46:51AM +0100, Philippe Bruhat (BooK) wrote: > (snip) > Will this work if I just have PERL_PATH in my config.mak in the root > directory? Should we be adding PERL_PATH to the generated > GIT-BUILD-OPTIONS file in the root, which gets sourced by test-lib? > > Something like the following (completely untested) patch?
Philippe, could you please help getting this topic unstuck with a "it works" or "it doesn't and here is a better solution"?
Show 12 quoted lines
> diff --git a/Makefile b/Makefile > index a10a60c..b9a8145 100644 > --- a/Makefile > +++ b/Makefile > @@ -1643,6 +1643,7 @@ GIT-CFLAGS: .FORCE-GIT-CFLAGS > # and the first level quoting from the shell that runs "echo". > GIT-BUILD-OPTIONS: .FORCE-GIT-BUILD-OPTIONS > @echo SHELL_PATH=\''$(subst ','\'',$(SHELL_PATH_SQ))'\' >$@ > + @echo PERL_PATH=\''$(subst ','\'',$(PERL_PATH_SQ))'\' >$@ > @echo TAR=\''$(subst ','\'',$(subst ','\'',$(TAR)))'\' >>$@ > @echo NO_CURL=\''$(subst ','\'',$(subst ','\'',$(NO_CURL)))'\' >>$@ > @echo NO_PERL=\''$(subst ','\'',$(subst ','\'',$(NO_PERL)))'\' >>$@