Re: [PATCH] Define $PERL_PATH in test-lib.sh

From: Philippe Bruhat (BooK) <book@cpan.org>
Date: Nov 11, 2009, 08:40 UTC
Message-ID: <20091111084014.GE8896@plop>
In-Reply-To: <7v7hty6so9.fsf@alter.siamese.dyndns.org>

On Tue, Nov 10, 2009 at 12:17:26PM -0800, Junio C Hamano wrote:

Show 19 quoted lines

> "Philippe Bruhat (BooK)" <book@cpan.org> writes:
> 
> > On Tue, Nov 10, 2009 at 01:26:53PM +0100, Johannes Sixt wrote:
> >> >  
> >> > +test -z "$NO_PERL" && test -z "$PERL_PATH" && export PERL_PATH=/usr/bin/perl
> >> 
> >> Wouldn't
> >> 
> >>    ... && export PERL_PATH=perl
> >> 
> >> be a safer fall-back?
> >
> > /usr/bin/perl is the value used in the top-level Makefile.
> > I used this for consistency.
> 
> Hmm, but that means two separate definitions in ./Makefile and
> t/test-lib.sh must be kept in sync forever, and there is not even a
> comment next to the line that requires such care in your patch to help
> people who might want to change these lines in the future.

Is there a way to obtain whatever value was computed in the Makefile, or should I just add a comment in all-caps saying "keep this in sync with the default value in the top level Makefile"? (and a more detailed commit message)

-- 
 Philippe Bruhat (BooK)

 Freedom is not an individual effort. Yours comes only when you grant others
 theirs.                             (Moral from Groo The Wanderer #5 (Epic))