git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Define $PERL_PATH in test-lib.sh

From
Jeff King <peff@peff.net>
Date
Nov 11, 2009, 08:43 UTC
Message-ID
<20091111084316.GA1799@sigill.intra.peff.net>
In-Reply-To
<20091111084014.GE8896@plop>
On Wed, Nov 11, 2009 at 09:40:14AM +0100, Philippe Bruhat (BooK) wrote:
Show 9 quoted lines
> > Hmm, but that means two separate definitions in ./Makefile and
> > t/test-lib.sh must be kept in sync forever, and there is not even a
> > comment next to the line that requires such care in your patch to help
> > people who might want to change these lines in the future.
> 
> Is there a way to obtain whatever value was computed in the Makefile,
> or should I just add a comment in all-caps saying "keep this in sync
> with the default value in the top level Makefile"? (and a more detailed
> commit message)
Yes. Did you miss the second half of my other message?
  http://article.gmane.org/gmane.comp.version-control.git/132561
-Peff
Previous: Philippe Bruhat (BooK)
Message 18 of 18 in “Define $PERL_PATH in test-lib.sh”
  1. Define $PERL_PATH in test-lib.shPhilippe Bruhat (BooK), Nov 10, 2009
  2. Jeff KingNov 10, 2009
  3. Philippe Bruhat (BooK)Nov 10, 2009
  4. Junio C HamanoNov 15, 2009
  5. Philippe Bruhat (BooK)Nov 16, 2009
  6. Make sure $PERL_PATH is defined when the test suite is run.Philippe Bruhat (BooK), Nov 16, 2009
  7. Junio C HamanoNov 17, 2009
  8. Philippe Bruhat (BooK)Nov 17, 2009
  9. Make sure $PERL_PATH is defined when the test suite is run.Philippe Bruhat (BooK), Nov 17, 2009
  10. Johannes SixtNov 17, 2009
  11. Philippe Bruhat (BooK)Nov 17, 2009
  12. Junio C HamanoNov 17, 2009
  13. Make sure $PERL_PATH is defined when the test suite is run.Philippe Bruhat (BooK), Nov 17, 2009
  14. Johannes SixtNov 10, 2009
  15. Philippe Bruhat (BooK)Nov 10, 2009
  16. Junio C HamanoNov 10, 2009
  17. Philippe Bruhat (BooK)Nov 11, 2009
  18. Jeff KingNov 11, 2009

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.