From: Junio C Hamano <gitster@pobox.com>
Date: Tue, 10 Nov 2009 20:17:26 GMT
Subject: Re: [PATCH] Define $PERL_PATH in test-lib.sh
Message-ID: <7v7hty6so9.fsf@alter.siamese.dyndns.org>
In-Reply-To: <20091110133427.GC8896@plop>

"Philippe Bruhat (BooK)" <book@cpan.org> writes:

> On Tue, Nov 10, 2009 at 01:26:53PM +0100, Johannes Sixt wrote:
>> >  
>> > +test -z "$NO_PERL" && test -z "$PERL_PATH" && export PERL_PATH=/usr/bin/perl
>> 
>> Wouldn't
>> 
>>    ... && export PERL_PATH=perl
>> 
>> be a safer fall-back?
>
> /usr/bin/perl is the value used in the top-level Makefile.
> I used this for consistency.

Hmm, but that means two separate definitions in ./Makefile and
t/test-lib.sh must be kept in sync forever, and there is not even a
comment next to the line that requires such care in your patch to help
people who might want to change these lines in the future.