git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v3 0/3]

From
Junio C Hamano <gitster@pobox.com>
Date
Feb 17, 2012, 17:03 UTC
Message-ID
<7v62f5v1d1.fsf@alter.siamese.dyndns.org>
In-Reply-To
<cover.1329472405.git.trast@student.ethz.ch>
Thomas Rast <trast@student.ethz.ch> writes:
> There were actually more mistakes lurking :-( so I am resending the
> whole series.

Ok, will requeue. The diff you attached to this cover letter looked at least halfway sane, compared to the previous round ;-), though it is not exactly clear what goes to lib-test-functions and what goes to lib-test (for example, you moved test_expect_success to 'test-functions', but it calls test_ok_ that is in 'test-lib', and test_ok_ is directly used by test_perf in the new 't/perf/perf-lib.sh'), making it harder for people to decide where to put their additions to the test infrastructure from now on. There needs a bit of description in the first patch to guide them.

I seem to be getting intermittent test failures, and every time the failing tests are different, when these three are queued to 'pu'. I didn't look for what goes wrong and how.

Thanks.
Previous: Thomas RastNext: Junio C Hamano
Message 9 of 19 in “Adding a performance framework”
  1. 0/3 Adding a performance frameworkThomas Rast, Feb 16, 2012
  2. 1/3 Move the user-facing test library to test-lib-functions.shThomas Rast, Feb 16, 2012
  3. Junio C HamanoFeb 16, 2012
  4. Thomas RastFeb 17, 2012
  5. 0/3 Thomas Rast, Feb 17, 2012
  6. 1/3 Move the user-facing test library to test-lib-functions.shThomas Rast, Feb 17, 2012
  7. 2/3 Introduce a performance testing frameworkThomas Rast, Feb 17, 2012
  8. 3/3 Add a performance test for git-grepThomas Rast, Feb 17, 2012
  9. Junio C HamanoFeb 17, 2012
  10. Junio C HamanoFeb 17, 2012
  11. Jeff KingFeb 18, 2012
  12. Junio C HamanoFeb 18, 2012
  13. Jeff KingFeb 18, 2012
  14. SIGPIPE handling (Re: [PATCH v3 0/3])Jonathan Nieder, Feb 18, 2012
  15. Jonathan NiederFeb 18, 2012
  16. Jeff KingFeb 18, 2012
  17. 2/3 Introduce a performance testing frameworkThomas Rast, Feb 16, 2012
  18. Jeff KingFeb 17, 2012
  19. 3/3 Add a performance test for git-grepThomas Rast, Feb 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.