Re: [PATCH v2 1/3] Move the user-facing test library to test-lib-functions.sh

From: Junio C Hamano <gitster@pobox.com>
Date: Feb 16, 2012, 22:14 UTC
Message-ID: <7v7gzmxw78.fsf@alter.siamese.dyndns.org>
In-Reply-To: <d5127b0051d354fc0c02666b972b853d1736d09c.1329428159.git.trast@student.ethz.ch>

Thomas Rast <trast@student.ethz.ch> writes:

Show 9 quoted lines

> This just moves all the user-facing functions to a separate file and
> sources that instead.
>
> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
> ---
>  t/test-lib-functions.sh |  835 +++++++++++++++++++++++++++++++++++++++++++++++
>  t/test-lib.sh           |  552 +-------------------------------
>  2 files changed, 840 insertions(+), 547 deletions(-)
>  create mode 100644 t/test-lib-functions.sh

I would have expected from the log description that the number of deleted lines would be about the same as the number of added lines, and the difference would primarily come from the addition of "include" aka "dot" ". ./test-lib-functions.sh" that becomes necessary in t/test-lib.sh, some boilerplate material at the beginning of the new file e.g. "#!/bin/sh", and copying (not moving) the same Copyright block to the new file.

But 835-552 = 283 feels way way more than that.  What else is going on?