From: Junio C Hamano Date: Fri, 17 Feb 2012 17:03:22 GMT Subject: Re: [PATCH v3 0/3] Message-ID: <7v62f5v1d1.fsf@alter.siamese.dyndns.org> In-Reply-To: Thomas Rast writes: > There were actually more mistakes lurking :-( so I am resending the > whole series. Ok, will requeue. The diff you attached to this cover letter looked at least halfway sane, compared to the previous round ;-), though it is not exactly clear what goes to lib-test-functions and what goes to lib-test (for example, you moved test_expect_success to 'test-functions', but it calls test_ok_ that is in 'test-lib', and test_ok_ is directly used by test_perf in the new 't/perf/perf-lib.sh'), making it harder for people to decide where to put their additions to the test infrastructure from now on. There needs a bit of description in the first patch to guide them. I seem to be getting intermittent test failures, and every time the failing tests are different, when these three are queued to 'pu'. I didn't look for what goes wrong and how. Thanks.