git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 1/3] Move the user-facing test library to test-lib-functions.sh

From
Thomas Rast <trast@inf.ethz.ch>
Date
Feb 17, 2012, 09:00 UTC
Message-ID
<8762f5rg14.fsf@thomas.inf.ethz.ch>
In-Reply-To
<7v7gzmxw78.fsf@alter.siamese.dyndns.org>
Junio C Hamano <gitster@pobox.com> writes:
Show 20 quoted lines
> Thomas Rast <trast@student.ethz.ch> writes:
>
>> This just moves all the user-facing functions to a separate file and
>> sources that instead.
>>
>> Signed-off-by: Thomas Rast <trast@student.ethz.ch>
>> ---
>>  t/test-lib-functions.sh |  835 +++++++++++++++++++++++++++++++++++++++++++++++
>>  t/test-lib.sh           |  552 +-------------------------------
>>  2 files changed, 840 insertions(+), 547 deletions(-)
>>  create mode 100644 t/test-lib-functions.sh
>
> I would have expected from the log description that the number of deleted
> lines would be about the same as the number of added lines, and the
> difference would primarily come from the addition of "include" aka "dot"
> ". ./test-lib-functions.sh" that becomes necessary in t/test-lib.sh, some
> boilerplate material at the beginning of the new file e.g. "#!/bin/sh",
> and copying (not moving) the same Copyright block to the new file.
>
> But 835-552 = 283 feels way way more than that.  What else is going on?

Hum, you're right. I checked with blame -C -C that I introduced no new lines, but I must accidentally have duplicated parts of it during conflict resolution.

-- 
Thomas Rast
trast@{inf,student}.ethz.ch
Previous: Junio C HamanoNext: Thomas Rast
Message 4 of 19 in “Adding a performance framework”
  1. 0/3 Adding a performance frameworkThomas Rast, Feb 16, 2012
  2. 1/3 Move the user-facing test library to test-lib-functions.shThomas Rast, Feb 16, 2012
  3. Junio C HamanoFeb 16, 2012
  4. Thomas RastFeb 17, 2012
  5. 0/3 Thomas Rast, Feb 17, 2012
  6. 1/3 Move the user-facing test library to test-lib-functions.shThomas Rast, Feb 17, 2012
  7. 2/3 Introduce a performance testing frameworkThomas Rast, Feb 17, 2012
  8. 3/3 Add a performance test for git-grepThomas Rast, Feb 17, 2012
  9. Junio C HamanoFeb 17, 2012
  10. Junio C HamanoFeb 17, 2012
  11. Jeff KingFeb 18, 2012
  12. Junio C HamanoFeb 18, 2012
  13. Jeff KingFeb 18, 2012
  14. SIGPIPE handling (Re: [PATCH v3 0/3])Jonathan Nieder, Feb 18, 2012
  15. Jonathan NiederFeb 18, 2012
  16. Jeff KingFeb 18, 2012
  17. 2/3 Introduce a performance testing frameworkThomas Rast, Feb 16, 2012
  18. Jeff KingFeb 17, 2012
  19. 3/3 Add a performance test for git-grepThomas Rast, Feb 16, 2012

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.