Re: [PATCH v3 0/3]

From: Jeff King <peff@peff.net>
Date: Feb 18, 2012, 00:51 UTC
Message-ID: <20120218005148.GA1940@sigill.intra.peff.net>
In-Reply-To: <7vk43lqbt8.fsf@alter.siamese.dyndns.org>

On Fri, Feb 17, 2012 at 03:28:51PM -0800, Junio C Hamano wrote:

Show 22 quoted lines

> Junio C Hamano <gitster@pobox.com> writes:
> 
> > Thomas Rast <trast@student.ethz.ch> writes:
> > ...
> > I seem to be getting intermittent test failures, and every time the
> > failing tests are different, when these three are queued to 'pu'. I didn't
> > look for what goes wrong and how.
> 
> False alarm. I suspect that it is jb/required-filter topic that is causing
> intermittent failures from convert.c depending on the timing of how fast
> filter subprocess dies vs how fast we consume its result or something.
> 
> Repeatedly running t0021 like this:
> 
>     $ cd t
>     $ while sh t0021-conversion.sh ; do :; done
> 
> under load seems to make it fail every once in a while.
> 
> test_must_fail: died by signal: git add test.fc
> 
> Are we dying on SIGPIPE or something?

I would be unsurprised if that is the case. Joey Hess mentioned similar issues with hooks a month or two ago. And I have been seeing intermittent failures of t5541 under load that I traced back to SIGPIPE. I've been meaning to dig further and come up with a good solution. Here's some previous discussion:

  http://article.gmane.org/gmane.comp.version-control.git/186291

I'd be happy if we just ignored SIGPIPE everywhere, but turned it on for the log family.

-Peff