git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only

From
Junio C Hamano <gitster@pobox.com>
Date
Jul 17, 2008, 05:38 UTC
Message-ID
<7v3am9m5ne.fsf@gitster.siamese.dyndns.org>
In-Reply-To
<20080717051833.GA3100@sigio.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 8 quoted lines
> On Tue, Jul 15, 2008 at 10:54:25PM -0700, Junio C Hamano wrote:
>
>> Anything that returns error() from its cmd_xxx() routine, for example,
>> would end up exiting with (-1).  Is it "such bogus" error codes, though?
>
> I think it is bogus, because it is being implicitly truncated to an
> unsigned 8-bit value (at least on Linux -- I have no idea what other
> platforms do).

"Only the least significant 8 bits (that is, status & 0377) shall be available to a waiting parent process". So it is not just "at least on Linux" but is a well defined behaviour.

http://www.opengroup.org/onlinepubs/000095399/functions/exit.html

I would however agree that when we do mean 255 we should probably write 255, not (-1). It is easier to document things that way.

Previous: Jeff KingNext: Jeff King
Message 9 of 15 in “t/test-lib.sh: Let test_must_fail fail on signals only”
  1. 1/2 t/test-lib.sh: Let test_must_fail fail on signals onlyStephan Beyer, Jul 12, 2008
  2. 2/2 t/: Use "test_must_fail git" instead of "! git"Stephan Beyer, Jul 12, 2008
  3. Jakub NarebskiJul 12, 2008
  4. Stephan BeyerJul 12, 2008
  5. t9001: Use "test_must_fail git" instead of "! git"Stephan Beyer, Jul 12, 2008
  6. Jeff KingJul 16, 2008
  7. Junio C HamanoJul 16, 2008
  8. Jeff KingJul 17, 2008
  9. Junio C HamanoJul 17, 2008
  10. Jeff KingJul 17, 2008
  11. Junio C HamanoJul 17, 2008
  12. Jeff KingJul 17, 2008
  13. Johannes SixtJul 17, 2008
  14. Junio C HamanoJul 17, 2008
  15. Stephan BeyerJul 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.