git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only

From
Johannes Sixt <j.sixt@viscovery.net>
Date
Jul 17, 2008, 07:22 UTC
Message-ID
<487EF31D.8090007@viscovery.net>
In-Reply-To
<20080717063856.GA10450@sigill.intra.peff.net>
Jeff King schrieb:
Show 8 quoted lines
> On Wed, Jul 16, 2008 at 11:31:41PM -0700, Junio C Hamano wrote:
>> Is it that somebody do not want 255 exit value, or anything that has 7th
>> bit set?  2488df8 (builtin run_command: do not exit with -1., 2007-11-13)
>> suggests otherwise at least for Windows runtime, so what we currently have
>> that does extra truncation ourselves might be sufficient.
> 
> Johannes will have to answer that; however, the truncation there does
> leave the extra 7th bit. Maybe & 0x7f would be more appropriate?

I never found out the real reason why -1 would not be recognized as "failure"; the conclusion of my debugging session was that MSYS bash has an issue, and I chose to append '& 0xff' because the documentation of WEXITSTATUS() says that it can receive only 8 bits of the exit() code. The intention of 2488df8 was to keep as much information as possible. But if that extra information hurts, we should better truncate to 7 bits.

The source code of Windows's C runtime suggests that any value that fits in 4 bytes can be supplied to exit() and can be received by cwait() (Windows's version of waitpid()); but I haven't looked at how MSYS implements waitpit() and whether it can receive that much information.

-- Hannes
Previous: Jeff KingNext: Junio C Hamano
Message 13 of 15 in “t/test-lib.sh: Let test_must_fail fail on signals only”
  1. 1/2 t/test-lib.sh: Let test_must_fail fail on signals onlyStephan Beyer, Jul 12, 2008
  2. 2/2 t/: Use "test_must_fail git" instead of "! git"Stephan Beyer, Jul 12, 2008
  3. Jakub NarebskiJul 12, 2008
  4. Stephan BeyerJul 12, 2008
  5. t9001: Use "test_must_fail git" instead of "! git"Stephan Beyer, Jul 12, 2008
  6. Jeff KingJul 16, 2008
  7. Junio C HamanoJul 16, 2008
  8. Jeff KingJul 17, 2008
  9. Junio C HamanoJul 17, 2008
  10. Jeff KingJul 17, 2008
  11. Junio C HamanoJul 17, 2008
  12. Jeff KingJul 17, 2008
  13. Johannes SixtJul 17, 2008
  14. Junio C HamanoJul 17, 2008
  15. Stephan BeyerJul 16, 2008

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.