Re: [PATCH 1/2] t/test-lib.sh: Let test_must_fail fail on signals only

From: Jeff King <peff@peff.net>
Date: Jul 17, 2008, 06:38 UTC
Message-ID: <20080717063856.GA10450@sigill.intra.peff.net>
In-Reply-To: <7vlk01komq.fsf@gitster.siamese.dyndns.org>

On Wed, Jul 16, 2008 at 11:31:41PM -0700, Junio C Hamano wrote:

Show 9 quoted lines

> > I started to fix the callsites that Stephan mentioned, but it really is
> > convenient to be able to 'return error("foo")' (or even return
> > func_that_calls_error(), and tracking down deep calls is time consuming
> > and error prone). So maybe we should just enhance the change from
> > 2488df84 and special case "-1" into "1"?
> 
> Didn't the patch to testsuite that triggered this thread talk about "small
> negative integer" not "-1"?  I suspect there might be other negative
> return values from cmd_foo(), although I haven't checked.

It did say that, but I never saw anything in the code except explicit "return -1" and "return error()". However, some of the diff code may end up with different values, as I didn't trace it all the way down. Stephan?

> Is it that somebody do not want 255 exit value, or anything that has 7th
> bit set?  2488df8 (builtin run_command: do not exit with -1., 2007-11-13)
> suggests otherwise at least for Windows runtime, so what we currently have
> that does extra truncation ourselves might be sufficient.

Johannes will have to answer that; however, the truncation there does leave the extra 7th bit. Maybe & 0x7f would be more appropriate?

-Peff