Re: [PATCH 2/2] t/: Use "test_must_fail git" instead of "! git"

From: Stephan Beyer <s-beyer@gmx.net>
Date: Jul 12, 2008, 21:43 UTC
Message-ID: <20080712214359.GA22323@leksak.fem-net>
In-Reply-To: <m3vdzbccoq.fsf@localhost.localdomain>

Hi,

Jakub Narebski wrote:

Show 12 quoted lines

> Stephan Beyer <s-beyer@gmx.net> writes:
> 
> > This patch changes every occurrence of "! git" -- with the meaning
> > that a git call has to fail -- into "test_must_fail git".
> > 
> > This is useful to
> 
> >  - advertise the use of "test_must_fail" for new tests.
> 
> Hmmm... I think advertising the use of 'test_must_fail' would be
> the best served by adding information about this function to
> t/README

This is true. This is not only true for test_must_fail, it is also true for stuff like test_tick, test_set_editor, test_cmp and the like.

But, well, t/README says also, that "existing programs are the best source of the information." And I think it is right ;-)

Regards,
  Stephan

-- 
Stephan Beyer <s-beyer@gmx.net>, PGP 0x6EDDD207FCC5040F