Re: MIME headers in introductory message (git send-email --compose)
- From
Jay Soffian <jaysoffian@gmail.com>
- Date
- Mar 26, 2008, 02:46 UTC
- Message-ID
- <76718490803251946t2640a8d2ga1e68ad06405c076@mail.gmail.com>
- In-Reply-To
- <20080325230649.GA5273@coredump.intra.peff.net>
On Tue, Mar 25, 2008 at 7:06 PM, Jeff King <peff@peff.net> wrote:
Show 15 quoted lines
> On Tue, Mar 25, 2008 at 08:31:16PM +0200, Teemu Likonen wrote: > > > By the way, 'git send-email --compose' does not add MIME headers to > > introductory message. All non-Ascii chars will output something > > undefined in receivers' end. > > > > I guess the right way would be to detect user's charset (locale) and add > > appropriate MIME headers. Also, the Subject field should be encoded if > > it contains non-Ascii characters. > > I just posted some patches to fix this; however, they always encode as > utf-8. I'm not sure what is the best way to find the user's encoding. > AIUI, locale environment variables are not enough, since, e.g., "en_US" > could come in iso8859-1 and utf-8 flavors. Is there a portable way to > figure this out? Should we be pulling it from .git/config?
I think so. There's no reason the message encoding necessarily matches the locale anyway. There are ways to guess, but I think .git/config is sanest with UTF-8 as the default.
j.