Re: MIME headers in introductory message (git send-email --compose)

From: Jeff King <peff@peff.net>
Date: Mar 25, 2008, 22:07 UTC
Message-ID: <20080325220743.GA5248@coredump.intra.peff.net>
In-Reply-To: <20080325215614.GA5189@coredump.intra.peff.net>

On Tue, Mar 25, 2008 at 05:56:14PM -0400, Jeff King wrote:

> We could be more clever about parsing format.headers and mark the "we
> have already added MIME" flag (I think we already have to do such
> parsing because of to/cc magic). But I have to wonder what the real goal

I started on this out of curiosity, and it _is_ really simple, but it's also wrong. It can't be right to set your MIME headers statically because some options (like --attach) might cause us to have to put in _different_ MIME headers. So we are left with either conflicting headers, disallowing --attach, ignoring some of your format.headers, or possibly picking out those headers and making them part of the header of that patch part of the multipart. All of which seem a bit ugly to me.

If this is something people really want, I think just adding an "always add mime headers" option makes the most sense.

-Peff