Re: [PATCH] Add MIME information to outgoing email
On Thu, Mar 13, 2008 at 06:14:36PM +0100, Samuel Tardieu wrote:
Show 5 quoted lines
> | It's supposed to handle this automatically if the commit message
> | contains non-ascii characters. What version of git were you using?
>
> A version from "next" from March 8:
> ea6cde37d54121c5a1e1da51e1cd5cf27bfa3904 (+ 1 unrelated patch)
Hmm, that is certainly recent enough.
> E.g, does "git format-patch a1eebf~1..a1eebf" add MIME headers for you
> without my patch?
Sorry, I don't have that commit. What repo is it in?
It does work for me with this simple test:
mkdir repo && cd repo && git init
echo content >file && git add file && git commit -m one
echo more >>file && git commit -a -m 'two
utf8 body: ñ'
git format-patch HEAD^
cat 0001-two.patch
I get:
-- >8 --
From a9e3222c0dca0a2b1e1a53ab9b7a7526ed359b79 Mon Sep 17 00:00:00 2001
From: Jeff King <peff@peff.net>
Date: Fri, 14 Mar 2008 09:27:30 -0400
Subject: [PATCH] two
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
utf8 body: ñ
---
file | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/file b/file
index d95f3ad..94b334d 100644
--- a/file
+++ b/file
@@ -1 +1,2 @@
content
+more
--
1.5.4.4.553.g83e84.dirty
-- 8< --
So I assume there is some bug in git that is being triggered by the
commit you mention.
-Peff
Jeff King <peff@peff.net>