Re: [PATCH] Add MIME information to outgoing email
- From
Brian Swetland <swetland@google.com>
- Date
- Mar 14, 2008, 11:21 UTC
- Message-ID
- <20080314112139.GA12846@bulgaria.corp.google.com>
- In-Reply-To
- <2008-03-13-20-05-55+trackit+sam@rfc1149.net>
[Samuel Tardieu <sam@rfc1149.net>]
Show 14 quoted lines
> On 13/03, Junio C Hamano wrote: > > | Samuel Tardieu <sam@rfc1149.net> writes: > | > | > Add MIME-Version/Content-Type/Content-Transfer-Encoding headers in > | > messages generated with git-format-patch. Without it, messages generated > | > without using --attach or --inline didn't have any content type information. > | > | Isn't that job for send-email (or user's MUA)? I really do not think we > | want to clutter format-patch output any more than necessary. > > Only format-patch knows what encoding has been used by itself to > generate the message. Doing it at any later stage would have to guess > what the correct charset is.
When the encoded string is entirely ascii except for one or two characters (such as occurs in a lot of patches I handle from people with names not represented in plain ascii) guessing later on seems to run pretty high risk of guessing wrong.
I've taken to manually adding UTF-8 content-type/transfer-encoding headers to avoid the routine mangling of my coworkers' names and would welcome a change to do this automatically.
Considering that UTF-8 is the expected default encoding (right?) for git metadata, it seems to be the sane thing to indicate if the default is unchanged.
Brian
Show 5 quoted lines
> > -- > To unsubscribe from this list: send the line "unsubscribe git" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html