Re: MIME headers in introductory message (git send-email --compose)
- From
Jeff King <peff@peff.net>
- Date
- Mar 25, 2008, 23:06 UTC
- Message-ID
- <20080325230649.GA5273@coredump.intra.peff.net>
- In-Reply-To
- <200803252031.17017.tlikonen@iki.fi>
On Tue, Mar 25, 2008 at 08:31:16PM +0200, Teemu Likonen wrote:
Show 7 quoted lines
> By the way, 'git send-email --compose' does not add MIME headers to > introductory message. All non-Ascii chars will output something > undefined in receivers' end. > > I guess the right way would be to detect user's charset (locale) and add > appropriate MIME headers. Also, the Subject field should be encoded if > it contains non-Ascii characters.
I just posted some patches to fix this; however, they always encode as utf-8. I'm not sure what is the best way to find the user's encoding. AIUI, locale environment variables are not enough, since, e.g., "en_US" could come in iso8859-1 and utf-8 flavors. Is there a portable way to figure this out? Should we be pulling it from .git/config? Neither the commitEncoding nor the logOutputEncoding really makes sense to reuse.
-Peff