Re: [PATCH 5/6] coverity: allow running on macOS
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 25, 2023, 11:52 UTC
- Message-ID
- <736713f0-ec71-0270-fab7-9300b09ad4ea@gmx.de>
- In-Reply-To
- <20230923070647.GB1471672@coredump.intra.peff.net>
Hi Peff,
On Sat, 23 Sep 2023, Jeff King wrote:
Show 9 quoted lines
> On Fri, Sep 22, 2023 at 10:42:02AM +0000, Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin <johannes.schindelin@gmx.de> > > > > For completeness' sake, let's add support for submitting macOS builds to > > Coverity Scan. > > I don't have any real problem with this, and it will check a few extra > bits of platform-specific code not covered elsewhere.
Just to make sure: The patch series, as presented here, will only build on `ubuntu-latest` by default, unless that is specifically overridden in the repository variables of `git/git`. It makes most sense to me that way.
> My big question would be: how much extra does this cost to run each > time?
I linked the example runs in the cover letter, which record the runtimes of the `build with cov-build` step as:
ubuntu-latest 5m20s windows-latest 17m40s macos-latest 1m59s
But again, I don't see much sense building `git/git` for anything else than `ubuntu-latest`, at least for now.
Ciao, Johannes