Re: [PATCH 3/6] coverity: allow overriding the Coverity project
- From
Jeff King <peff@peff.net>
- Date
- Sep 26, 2023, 14:45 UTC
- Message-ID
- <20230926144515.GB1897653@coredump.intra.peff.net>
- In-Reply-To
- <4e0f404e-0c49-b085-c35d-be53b0381402@gmx.de>
On Tue, Sep 26, 2023 at 04:02:27PM +0200, Johannes Schindelin wrote:
Show 13 quoted lines
> > > > This may not matter all that much, because I don't expect most > > > > people to set this up for their forks > > > > > > Except, of course, Git for Windows. And that has been the entire > > > motivation for me to work on this here patch series in the first > > > place, so it would be rather pointless if I could not override this in > > > the git-for-windows/git fork. > > > > I didn't at all mean that it should not be possible to override it. > > Aha! The "This" in "This may not matter all that much" was referring to > the `git` instead of the `COVERITY_PROJECT` part. That had not been clear > to me.
I think we are on the same page now, but I wanted to elaborate here because this miscommunication interested me. The "this" in what I wrote was actually the "X" in:
This may not matter because of $FOO, but X.
The X got snipped in what you quoted, but was "But I just wondered if a better default would would be...". I certainly did not help with readability by inserting a huge parenthetical phrase and putting in a full-stop and starting the new sentence on "But" (my ninth grade English teacher would be horrified).
I mention it mostly as a note to myself about trying to make sure I keep my writing clear and readable (and a cautionary tale for others!).
-Peff