Re: [PATCH 3/6] coverity: allow overriding the Coverity project
- From
Johannes Schindelin <johannes.schindelin@gmx.de>
- Date
- Sep 26, 2023, 14:02 UTC
- Message-ID
- <4e0f404e-0c49-b085-c35d-be53b0381402@gmx.de>
- In-Reply-To
- <20230925121157.GB1623701@coredump.intra.peff.net>
Hi Jeff,
On Mon, 25 Sep 2023, Jeff King wrote:
Show 19 quoted lines
> On Mon, Sep 25, 2023 at 01:52:47PM +0200, Johannes Schindelin wrote: > > > On Sat, 23 Sep 2023, Jeff King wrote: > > > > > On Fri, Sep 22, 2023 at 10:42:00AM +0000, Johannes Schindelin via GitGitGadget wrote: > > > > > > > +# By default, the builds are submitted to the Coverity project > > > > +# `git`. To override this, set the repository variable > > > > +# `COVERITY_PROJECT`. > > > > > > This may not matter all that much, because I don't expect most > > > people to set this up for their forks > > > > Except, of course, Git for Windows. And that has been the entire > > motivation for me to work on this here patch series in the first > > place, so it would be rather pointless if I could not override this in > > the git-for-windows/git fork. > > I didn't at all mean that it should not be possible to override it.
Aha! The "This" in "This may not matter all that much" was referring to the `git` instead of the `COVERITY_PROJECT` part. That had not been clear to me.
> I meant that the default should be $user/$fork from the Actions > environment,
I'd much rather default to the value needed by the Git project than a value that may be needed by any other user. I do aim to support the Git project with this patch series, first and foremost.
Ciao, Johannes