Re: [PATCH 4/6] coverity: support building on Windows
- From
Jeff King <peff@peff.net>
- Date
- Sep 23, 2023, 07:03 UTC
- Message-ID
- <20230923070327.GA1471672@coredump.intra.peff.net>
- In-Reply-To
- <14cdefff08244f9b5e2ee1fa2a78cfd3e58c14d2.1695379323.git.gitgitgadget@gmail.com>
On Fri, Sep 22, 2023 at 10:42:01AM +0000, Johannes Schindelin via GitGitGadget wrote:
Show 5 quoted lines
> From: Johannes Schindelin <johannes.schindelin@gmx.de> > > By adding the repository variable `ENABLE_COVERITY_SCAN_ON_OS` with a > value, say, `["windows-latest"]`, this GitHub workflow now runs on > Windows, allowing to analyze Windows-specific issues.
Makes sense. I figured we'd key this on COVERITY_PLATFORM itself, but I guess we need to map Actions environments to Coverity platform names, so starting with the Actions names makes sense.
> +# The workflow runs on `ubuntu-latest` by default. This can be overridden by setting > +# the repository variable `ENABLE_COVERITY_SCAN_ON_OS` to a JSON string array specifying > +# the operating systems, e.g. `["ubuntu-latest", "windows-latest"]`.
OK. I was envisioning that we'd just run on one platform, and maybe git-for-windows would run on another. But it does not hurt to be able to do both from one repo. I'm not sure how Coverity presents that, but it should be able to figure out based on "version" and "platform" fields that they are two builds of the same version (and not, say, one overriding the other as the "latest").
-Peff