git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH v2 5/6] coverity: allow running on macOS

From
Johannes Schindelin via GitGitGadget <gitgitgadget@gmail.com>
Date
Sep 25, 2023, 11:51 UTC
Message-ID
<3d24b6f3b22f0c3b283f1c7a853c7784342588ad.1695642662.git.gitgitgadget@gmail.com>
In-Reply-To
<pull.1588.v2.git.1695642662.gitgitgadget@gmail.com>
From: Johannes Schindelin <johannes.schindelin@gmx.de>

For completeness' sake, let's add support for submitting macOS builds to Coverity Scan.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
 .github/workflows/coverity.yml | 22 ++++++++++++++++++++--
 1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/coverity.yml b/.github/workflows/coverity.yml
index ca364c3d692..53f9ee6a418 100644
--- a/.github/workflows/coverity.yml
+++ b/.github/workflows/coverity.yml
@@ -43,7 +43,7 @@ jobs:
         if: contains(matrix.os, 'windows')
         uses: git-for-windows/setup-git-for-windows-sdk@v1
       - run: ci/install-dependencies.sh
-        if: contains(matrix.os, 'ubuntu')
+        if: contains(matrix.os, 'ubuntu') || contains(matrix.os, 'macos')
         env:
           runs_on_pool: ${{ matrix.os }}
 
@@ -56,10 +56,17 @@ jobs:
           *windows*)
             COVERITY_PLATFORM=win64
             COVERITY_TOOL_FILENAME=cov-analysis.zip
+            MAKEFLAGS=-j$(nproc)
+            ;;
+          *macos*)
+            COVERITY_PLATFORM=macOSX
+            COVERITY_TOOL_FILENAME=cov-analysis.dmg
+            MAKEFLAGS=-j$(sysctl -n hw.physicalcpu)
             ;;
           *ubuntu*)
             COVERITY_PLATFORM=linux64
             COVERITY_TOOL_FILENAME=cov-analysis.tgz
+            MAKEFLAGS=-j$(nproc)
             ;;
           *)
             echo '::error::unhandled OS ${{ matrix.os }}' >&2
@@ -68,6 +75,7 @@ jobs:
           esac
           echo "COVERITY_PLATFORM=$COVERITY_PLATFORM" >>$GITHUB_ENV
           echo "COVERITY_TOOL_FILENAME=$COVERITY_TOOL_FILENAME" >>$GITHUB_ENV
+          echo "MAKEFLAGS=$MAKEFLAGS" >>$GITHUB_ENV
           MD5=$(curl https://scan.coverity.com/download/$COVERITY_LANGUAGE/$COVERITY_PLATFORM \
                    --fail \
                    --form token='${{ secrets.COVERITY_SCAN_TOKEN }}' \
@@ -99,6 +107,16 @@ jobs:
             mkdir $RUNNER_TEMP/cov-analysis &&
             tar -xzf $RUNNER_TEMP/$COVERITY_TOOL_FILENAME --strip 1 -C $RUNNER_TEMP/cov-analysis
             ;;
+          *.dmg)
+            cd $RUNNER_TEMP &&
+            attach="$(hdiutil attach $COVERITY_TOOL_FILENAME)" &&
+            volume="$(echo "$attach" | cut -f 3 | grep /Volumes/)" &&
+            mkdir cov-analysis &&
+            cd cov-analysis &&
+            sh "$volume"/cov-analysis-macosx-*.sh &&
+            ls -l &&
+            hdiutil detach "$volume"
+            ;;
           *.zip)
             cd $RUNNER_TEMP &&
             mkdir cov-analysis-tmp &&
@@ -120,7 +138,7 @@ jobs:
         run: |
           export PATH="$RUNNER_TEMP/cov-analysis/bin:$PATH" &&
           cov-configure --gcc &&
-          cov-build --dir cov-int make -j$(nproc)
+          cov-build --dir cov-int make
       - name: package the build
         run: tar -czvf cov-int.tgz cov-int
       - name: submit the build to Coverity Scan
-- 
gitgitgadget
Previous: Johannes Schindelin via GitGitGadgetNext: Jeff King
Message 34 of 37 in “Add a GitHub workflow to submit builds to Coverity Scan”
  1. 0/6 Add a GitHub workflow to submit builds to Coverity ScanJohannes Schindelin via GitGitGadget, Sep 22, 2023
  2. 3/6 coverity: allow overriding the Coverity projectJohannes Schindelin via GitGitGadget, Sep 22, 2023
  3. Jeff KingSep 23, 2023
  4. Johannes SchindelinSep 25, 2023
  5. Jeff KingSep 25, 2023
  6. Johannes SchindelinSep 26, 2023
  7. Junio C HamanoSep 26, 2023
  8. Jeff KingSep 26, 2023
  9. Junio C HamanoSep 26, 2023
  10. Jeff KingSep 26, 2023
  11. 2/6 coverity: cache the Coverity Build ToolJohannes Schindelin via GitGitGadget, Sep 22, 2023
  12. Jeff KingSep 23, 2023
  13. Johannes SchindelinSep 25, 2023
  14. 1/6 ci: add a GitHub workflow to submit Coverity scansJohannes Schindelin via GitGitGadget, Sep 22, 2023
  15. Jeff KingSep 23, 2023
  16. Johannes SchindelinSep 25, 2023
  17. Jeff KingSep 25, 2023
  18. 4/6 coverity: support building on WindowsJohannes Schindelin via GitGitGadget, Sep 22, 2023
  19. Jeff KingSep 23, 2023
  20. 6/6 coverity: detect and report when the token or project is incorrectJohannes Schindelin via GitGitGadget, Sep 22, 2023
  21. Jeff KingSep 23, 2023
  22. Johannes SchindelinSep 25, 2023
  23. Jeff KingSep 25, 2023
  24. 5/6 coverity: allow running on macOSJohannes Schindelin via GitGitGadget, Sep 22, 2023
  25. Jeff KingSep 23, 2023
  26. Johannes SchindelinSep 25, 2023
  27. Jeff KingSep 25, 2023
  28. 0/6 Add a GitHub workflow to submit builds to Coverity ScanJohannes Schindelin via GitGitGadget, Sep 25, 2023
  29. 3/6 coverity: allow overriding the Coverity projectJohannes Schindelin via GitGitGadget, Sep 25, 2023
  30. 2/6 coverity: cache the Coverity Build ToolJohannes Schindelin via GitGitGadget, Sep 25, 2023
  31. 1/6 ci: add a GitHub workflow to submit Coverity scansJohannes Schindelin via GitGitGadget, Sep 25, 2023
  32. 4/6 coverity: support building on WindowsJohannes Schindelin via GitGitGadget, Sep 25, 2023
  33. 6/6 coverity: detect and report when the token or project is incorrectJohannes Schindelin via GitGitGadget, Sep 25, 2023
  34. 5/6 coverity: allow running on macOSJohannes Schindelin via GitGitGadget, Sep 25, 2023
  35. Jeff KingSep 25, 2023
  36. Junio C HamanoSep 25, 2023
  37. Johannes SchindelinSep 26, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.