Re: [PATCH v1 06/25] contrib: remove 'diffall'

From: Felipe Contreras <felipe.contreras@gmail.com>
Date: May 9, 2014, 15:20 UTC
Message-ID: <536cf242394eb_ce316372ec42@nysa.notmuch>
In-Reply-To: <CAFouetj=30Wd_CDiXA0UqqKNdfJSv+C5mWbMJPOkEdqxr7k54w@mail.gmail.com>

Tim Henigan wrote:

Show 21 quoted lines

> On Thu, May 8, 2014 at 5:58 PM, Felipe Contreras <felipe.contreras@gmail.com
> > wrote:
> 
> > No activity since 2010, no tests.
> >
> > Cc: Tim Henigan <tim.henigan@gmail.com>
> > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> > ---
> >  contrib/diffall/README      |  31 ------
> >  contrib/diffall/git-diffall | 257
> > --------------------------------------------
> >  2 files changed, 288 deletions(-)
> >  delete mode 100644 contrib/diffall/README
> >  delete mode 100755 contrib/diffall/git-diffall
> >
> 
> 
> I see no problem with removing this script from contrib.  However, the
> commit message should mention that git-difftool learned all the
> features of git-diffall when the '--dir-diff' option was added in
> v1.7.11 (ca. June 2012).

Will do.

> Also, the script was first added to contrib in Feb. 2012, so "no
> activity since 2010" is incorrect.

Ah, sorry about that.

-- 
Felipe Contreras